fix(treeview):multiple modifications and optimizations #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Fix change parameter from program not correct affect node state.(Value,Open,Active,Openall) 2.Change parameter from program(Open,Active,Value) should not trigger event. 3.Optimize search execution efficiency.
capdiem
requested changes
Jan 31, 2024
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
1. The _oldActive variable was mistakenly used as _OldValue. 2. Modify ValueChanged and OnInput trigger event data.
1.remove useless code 2.add search changed logic
Remove oldsearch judgment to prevent incorrect data retrieval during dynamic loading
capdiem
requested changes
Feb 1, 2024
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
| if (_oldItemsKeys == newKeys) return false; | ||
| _oldItemsKeys = newKeys; | ||
| return true; | ||
| } |
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
capdiem
requested changes
Feb 1, 2024
src/Component/BlazorComponent/Components/Treeview/BTreeview.razor.cs
Outdated
Show resolved
Hide resolved
capdiem
approved these changes
Feb 1, 2024
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Fix change parameter from program not correct affect node state.(Value,Open,Active,Openall)
2.Change parameter from program(Open,Active,Value) should not trigger event.
3.Optimize search execution efficiency.