Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idgenerator): Add IIdGenerator And Add MasaApp #188

Merged
merged 22 commits into from
Aug 10, 2022

Conversation

zhenlei520
Copy link
Contributor

Description

  • Add IIdGenerator And Add MasaApp
  • Remove the IsDefault property in Caller

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…sa.BuildingBlocks.Data.Contracts.Paginated namespace
…to feature/idgenerator

# Conflicts:
#	src/BuildingBlocks/Data/Masa.BuildingBlocks.Data/_Imports.cs
#	src/Contrib/Data/Orm/EFCore/Masa.Contrib.Data.EFCore/_Imports.cs
#	src/Contrib/StackSdks/Tests/Masa.Contrib.StackSdks.Pm.Tests/_Imports.cs
@zhenlei520 zhenlei520 requested a review from doddgu August 9, 2022 05:40
…to feature/idgenerator

# Conflicts:
#	src/Contrib/Service/Masa.Contrib.Service.MinimalAPIs/_Imports.cs

namespace Masa.Contrib.Service.MinimalAPIs.BackgroundServices;

public class InitializeMasaAppHostedService : BackgroundService
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's a background service?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Processed

@zhenlei520 zhenlei520 requested a review from doddgu August 9, 2022 08:25
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…SA.Framework into feature/idgenerator

# Conflicts:
#	src/Contrib/Data/IdGenerator/NormalGuid/Masa.Contrib.Data.IdGenerator.NormalGuid.Tests/NormalGuidGeneratorTest.cs
#	src/Contrib/Data/IdGenerator/SequentialGuid/Masa.Contrib.Data.IdGenerator.SequentialGuid.Tests/SequentialGuidGeneratorTest.cs
#	src/Contrib/Service/Caller/Tests/Masa.Contrib.Service.Caller.Tests/CallerTest.cs
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codding-y codding-y merged commit b3598c1 into main Aug 10, 2022
@codding-y codding-y deleted the feature/idgenerator branch August 10, 2022 07:24
@zhenlei520 zhenlei520 mentioned this pull request Aug 16, 2022
11 tasks
@zhenlei520 zhenlei520 added this to the 0.6.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants