Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated dependencies #1062

Closed
jbraithwaite opened this issue Mar 15, 2015 · 4 comments
Closed

Outdated dependencies #1062

jbraithwaite opened this issue Mar 15, 2015 · 4 comments

Comments

@jbraithwaite
Copy link

Is there a reason d3 needs to be <= 3.5.0 in the dependencies?

I ran the test suite with updated deps (even v3.5.5 of d3) and everything passed.

"dependencies": {
    "d3": "^3.5.5"
  },
  "devDependencies": {
    "grunt": "^0.4.5",
    "grunt-contrib-concat": "~0.5.1",
    "grunt-contrib-cssmin": "^0.12.2",
    "grunt-contrib-jasmine": "~0.8.2",
    "grunt-contrib-jshint": "~0.11.0",
    "grunt-contrib-uglify": "~0.8.0",
    "grunt-contrib-watch": "^0.6.1",
    "grunt-sass": "^0.18.1",
    "load-grunt-tasks": "~3.1.0"
  }
@axelson
Copy link

axelson commented Mar 26, 2015

+1

@aendra-rininsland
Copy link
Member

I'm making this the canonical issue about updating D3 dependencies. Please also see PR #1166, which has a bunch of discussion about the topic.

@missingdays
Copy link

Is this still relevant? C3 update d3 to ~3.5.0. Does it fix your problem?

@panthony
Copy link
Contributor

D3 was updated to v4, closing as irrelevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants