Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Public API #4

Merged
merged 6 commits into from
Jan 15, 2023
Merged

Use Public API #4

merged 6 commits into from
Jan 15, 2023

Commits on Jan 15, 2023

  1. [BREAKING] Override public API to filter cached name key 

    Rewrite the plugin to avoid private APIs:

  * Remove custom testenv conf key: ignore_env_name_mismatch and
    ignore_envname_mismatch
  * Use existing conf key `runner` to opt-in to ignore_env_name_mismatch
    behavior
  * Return a subclass of `Info` that filters out the "name" key from
    `ToxEnv.__name__` section
    * When this plugin is active, the ToxEnv cached info will NOT contain a
      "name" key at all, so there will be no name key to conflict, thus nothing
      needs to be overridden in the private `_content` dictionary.

All tests are rewritten and vastly simplified, as there are fewer branch points
in the new implementation.

fix #3
    @masenf
    masenf committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    06d3035 View commit details
    Browse the repository at this point in the history

  2. Update docs and examples to use runner =

    @masenf
    masenf committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    38b0386 View commit details
    Browse the repository at this point in the history

  3. Add copyright notice to primary module 

    Update copyright year to 2023
    @masenf
    masenf committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    c9afa6a View commit details
    Browse the repository at this point in the history

  4. README.md: update changelog for v0.2

    @masenf
    masenf committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    42802bc View commit details
    Browse the repository at this point in the history

  5. README.md: update installation/usage information 

    Add links to tox documentation

Add section about vendoring the plugin
    @masenf
    masenf committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    a4fd770 View commit details
    Browse the repository at this point in the history

  6. test_ignore_env_name_mismatch: unit tests for FilteredInfo 

    Since FilteredInfo can accept generic filter_keys and filter_section, add test
cases to ensure the less common default branches are covered, even though the
plugins don't directly use them (yet)
    @masenf
    masenf committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    2682f02 View commit details
    Browse the repository at this point in the history