set envconfig.deps during tox_configure
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for each of the selected environments, update the
deps with the lock file at configure time, if it
exists
if the user passes --pip-compile, then don't update
the deps, so that tox_testenv_installdeps can
access them.
this has 3 very nice side effects:
* --pip-compile now implies --recreate, because
the compiled environment is created from the
pin file, it won't match the unmodified deps
passed when --pip-compile is present.
* --ignore-pins now implies --recreate, for the
same reason...and un-ignoring the pins will
also recreate the environment.
* normal runs now do NOT recreate the environment
which it was doing _every_ time before
All around major win.
ensure that deps are overwritten early in the envconfig, provided that pins are not ignore and pip-compile will not be called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for each of the selected environments, update the
depswith the lock file at configure time, if it existsif the user passes
--pip-compile, then don't update thedeps, so thattox_testenv_installdepscan access them.this has 3 very nice side effects:
--pip-compilenow implies--recreate, because the compiled environment is created from the pin file, it won't match the unmodifieddepspassed when--pip-compileis present.--ignore-pinsnow implies--recreate, for the same reason...and un-ignoring the pins will also recreate the environment.All around major win.
Replaces #10