Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is an issue for other people, but having calls to
setState(...)
inside of timeouts in the Pickselect component would trigger the typical error:The timeouts were required to know whether clicks were happening inside the component or outside, for hiding the dropdown menu on blur.
To solve this it uses an extra event on
DropdownMenuItem
"onWillFocus" which indicates whether another element is going to be focused. This way theDropdownMenu
knows before receiving the blur event.This works well for us so I figured it would be nice to contribute it back.