win... not supporting permissions

mashpie · Feb 6, 2016 · 83dda17 · 83dda17
1 parent c0a076e
commit 83dda17
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -61,7 +61,7 @@ i18n.configure({
     // where to store json files - defaults to './locales' relative to modules directory
     directory: './mylocales',
 
-    // controll mode on directory creation - defaults to NULL which defaults to umask of process user
+    // controll mode on directory creation - defaults to NULL which defaults to umask of process user. Setting has no effect on win.
     directoryPermissions: '755',
 
     // whether to write new locale information to disk - defaults to true

diff --git a/test/i18n.configurePermissions.js b/test/i18n.configurePermissions.js
@@ -5,6 +5,8 @@ var i18n = process.env.EXPRESS_COV ? require('../i18n-cov') : require('../i18n')
     path = require("path"),
     fs = require('fs');
 
+var isWin = /^win/.test(process.platform);
+
 describe('Module Config (directoryPermissions)', function () {
 
   var testScope = {};
@@ -47,7 +49,8 @@ describe('Module Config (directoryPermissions)', function () {
     });
     testScope.__('Hello');
     var stat = fs.lstatSync('./customlocales');
-    should.equal('40700', parseInt(stat.mode.toString(8), 10));
+    var mode = isWin? '40666':'40700';
+    should.equal(mode, parseInt(stat.mode.toString(8), 10));
     should.exist(stat);
   });
 
@@ -62,7 +65,8 @@ describe('Module Config (directoryPermissions)', function () {
     });
     testScope.__('Hello');
     var stat = fs.lstatSync('./customlocales');
-    should.equal('40750', parseInt(stat.mode.toString(8), 10));
+    var mode = isWin? '40666':'40750';
+    should.equal(mode, parseInt(stat.mode.toString(8), 10));
     should.exist(stat);
   });