Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ i18n.disableReload; ~ fs.watch->chokidar; #308

Closed
wants to merge 43 commits into from
Closed

Conversation

Spown
Copy link

@Spown Spown commented May 7, 2017

A way to stop watching files (autoReload: true)
#288

~ fs.watch->chokidar;
@coveralls
Copy link

coveralls commented May 7, 2017

Coverage Status

Coverage increased (+0.02%) to 97.93% when pulling 2310c9a on Spown:master into 11d89da on mashpie:master.

@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.4%) to 97.541% when pulling 9b98552 on Spown:master into 11d89da on mashpie:master.

@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 3a7042d on Spown:master into 11d89da on mashpie:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 0630df4 on Spown:master into 11d89da on mashpie:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 0630df4 on Spown:master into 11d89da on mashpie:master.

@coveralls
Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 2e0f7cb on Spown:master into 11d89da on mashpie:master.

@coveralls
Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 351f7ac on Spown:master into 11d89da on mashpie:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 351f7ac on Spown:master into 11d89da on mashpie:master.

@coveralls
Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 351f7ac on Spown:master into 11d89da on mashpie:master.

@coveralls
Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage decreased (-0.4%) to 97.546% when pulling 15855e8 on Spown:master into 11d89da on mashpie:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 3100c53 on Spown:master into 11d89da on mashpie:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 97.536% when pulling 3100c53 on Spown:master into 11d89da on mashpie:master.

@mashpie mashpie added this to Todo in autoReload, updateFiles review & fixes via automation Aug 15, 2020
@mashpie
Copy link
Owner

mashpie commented Aug 15, 2020

sorry - PR introduces far too many changes and conflicts at once. But I will consider adding i18n.disableReload

@mashpie mashpie closed this Aug 15, 2020
@Spown
Copy link
Author

Spown commented Aug 15, 2020

Yeah, I should've made a dedicated branch for this PR, most of the stuff here doesn't belong.

@mashpie
Copy link
Owner

mashpie commented Aug 16, 2020

No worries - Your PR pointed out some nice improvements. Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants