Default to 1st non-empty language query parameter #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meters; instead use the the first non-empty query parameter.
|
jshint needs to get fixed... (will be replaced by standard in future). Will do so on my own short before merge & publish. |
|
Add unit tests.
|
Fixed jshint warnings. |
|
@RhobW Thanks a lot! I started collecting issues & PRs for 0.11.0 and was just about to merge. Perfect timing 👍 |
mashpie
added a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not throw an exception if there are multiple "language" query parameters and the first is empty.
Instead use the the first non-empty query parameter.
This is an extension of the following fix:
#380