Prevent locale data corruption #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corruption of locale data on an application crash. This can happen in environments using supervisor to restart node automatically.
|
Thanks for contributing :) |
peecky
pushed a commit
to peecky/i18n-node
that referenced
this pull request
Apr 7, 2014
Fix usage of res.locals in Express 3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for creating this cool module!
During using it I noticed that the locale data is reinitialized when the application crashed. I use supervisor to restart my node app automatically when files change. This leads to application crashes like
DEBUG: crashing child
DEBUG: Starting child process with 'node app.js'
quite often. Afterwards all my locale data was lost and a new locale file was created. After changing the write behaviour to create a temp file first and rename it then this issue did not occur any more.
I hope you find it useful.
Regards,
Patrick