Fix panic caused by analyzing a cluster that is not found #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On `analyze` when a cluster is not found the code continued to execute the analysis functions which then resulted in panic at `./kubectl-fdb/cmd/analyze.go:224` since `cluster` passed into the analysis functions would be `nil`. The changes here fix the issue by only calling analysis functions if no error is returned upon getting the cluster object.
|
fixed via contributors PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
analyzewhen a cluster is not found the code continued to execute the analysis functions which then resulted in panic at./kubectl-fdb/cmd/analyze.go:224sinceclusterpassed into the analysis functions would benil.The changes here fix the issue by only calling analysis functions if no error is returned upon getting the cluster object.
Note: cannot open this PR in original repo due to permission restrictions.