Skip to content

Commit

Permalink
Add note that the convenience parsers are not cached to readme
Browse files Browse the repository at this point in the history
An even better solution would be to cache them, but *just* caching
them seems redundant with the existing cache, so things would need to
be rethought.

Fixes ua-parser#97
  • Loading branch information
masklinn committed Apr 27, 2022
1 parent 934bfab commit 40ad449
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,16 @@ Extract browser data from user-agent string
'minor': '0',
'patch': '2272'}
..
⚠️The convenience parsers (``ParseUserAgent``, ``ParseOs``, and
``ParseDevice``) currently have no caching, which can result in
degraded performances when parsing large amounts of identical
user-agents (which might occur for real-world datasets).

In that case, prefer using ``Parse`` and extracting the
sub-component you need from the resulting dictionary.

Extract OS information from user-agent string
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expand Down

0 comments on commit 40ad449

Please sign in to comment.