Revert "Revert pgtkconn removal"

[masm11]

I can't reproduce the freeze,
so I revert #10 as I wrote in #9.

[masm11]

and freezing...

what mistake am i doing...?

[masm11]

There seemed to be a build mistake.

[fejfighter]

I had it for a little while late last night on one of my dev branches,

a make bootstrap & make install seemed to help

must have been linking something in a broken way.

[masm11]

@fejfighter
Hi,
thanks for the advice.

I debugged and resolved. I pushed commits to pgtk.

I confirmed:

• stable cursor blink
• no freeze
• sane cpu load even if with < /dev/null

[fejfighter]

Sorry,

I misread your comment this morning,

I did not realise that you had found a better solution, good work, it's much more elegant.

[masm11]

Hi, @fejfighter ,

I want to merge this fork to mainline.

When I do, I'll need to assign copyright of my code in this fork to FSF.

Also, this fork contains your code.
Do you agree that you assign copyright of your code in this fork to FSF?

[fejfighter]

Hey,

That would be great,
I assume that I will need to sign paperwork as well?

for now: Yes I do agree to assign my code to the FSF.

When are you hoping to merge it in? I guess some time after 27 is released?
There are still a couple of missing features that would be nice to handle.

[masm11]

@fejfighter

I assume that I will need to sign paperwork as well?

I don't know about the detail.
When I tell the developer team about the merge request, they will tell me the detail, I think.

for now: Yes I do agree to assign my code to the FSF.

Thank you.

When are you hoping to merge it in? I guess some time after 27 is released?

master is different branch from 27, so anytime may be ok, I think.

There are still a couple of missing features that would be nice to handle.

OK, I'll wait for them.

[skangas]

I assume that I will need to sign paperwork as well?

Yes, the fastest way is to e-mail emacs-devel@gnu.org and ask for the copyright assignment form to get the process started.

Best regards,
Stefan Kangas

[dgutov]

There is one other thing. The patches submitted to Emacs require commit messages written to the GNU standard.

We could turn this whole branch into one combined patch with a title "Pure GTK port added" and a mechanical description of the changes. But if you'd like to keep the changes history, it would require some more work it splitting it up and writing messages for each. At it seems like @fejfighter might be the person for that job, if interested.

[fejfighter]

@dgutov early work in #23

[dgutov]

@fejfighter Thank you. Am I correct to assume that you haven't worked on the commit messages themselves yet? The Emacs project requires them in a particular format, exemplified here: https://www.gnu.org/software/emacs/manual/html_node/emacs/Format-of-ChangeLog.html#Format-of-ChangeLog

Just in case this is a surprise: we do have commands in Emacs that help in creating such entries, so you don't type every file name, function name, paren and colon by hand.

[fejfighter]

@dgutov, correct, my focus was on rebasing cleanly onto master and folding in fixups while trying to maintain some "thematic" commits, I may have been a little ambitious and will need to compress more of them.

I think I would have been more surprised if there wasn't a command, but I hand not thought of using it for the commits, so thanks!

[masm11]

@dgutov Thanks for your advice.

I learned how to do that in magit today.