Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

committing #1

Merged
merged 1 commit into from
Aug 28, 2018
Merged

committing #1

merged 1 commit into from
Aug 28, 2018

Conversation

calebmcquaid
Copy link
Collaborator

comment

Copy link
Owner

@mason-stewart mason-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@@ -12,7 +12,7 @@

<img src="images/sign_up_99_51.png" width="99" height="51">
<div class="sign_up-container">
<button class="sign_up">Don't Sign Up</button>
<button class="sign_up">Do Sign Up</button>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this. Users shouldn't sign up.

👎

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind this is great

@calebmcquaid calebmcquaid merged commit 12f3cbf into master Aug 28, 2018
@calebmcquaid calebmcquaid deleted the 2nd_branch branch August 28, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants