Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply cross-env to lower-level package.jsons to fix Windows-specific … #106

Merged
merged 2 commits into from Apr 22, 2020
Merged

Apply cross-env to lower-level package.jsons to fix Windows-specific … #106

merged 2 commits into from Apr 22, 2020

Conversation

willyrk1
Copy link
Contributor

…script errors.

Before submitting a pull request, please make sure the following is done:

  1. Make sure your updates are reflected in both the React and HTML side of MDL.
  2. If you've fixed a bug or added code that should be tested, add tests!
  3. Make sure the test suite passes (npm test).

tarikhamilton
tarikhamilton approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@tarikhamilton tarikhamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 8)

@willyrk1
Copy link
Contributor Author

Nice 8)

Of course - it was your idea! lol

@tarikhamilton tarikhamilton merged commit a5525b5 into master Apr 22, 2020
@tarikhamilton tarikhamilton deleted the add-cross-env-at-lower-levels branch April 22, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarikhamilton tarikhamilton tarikhamilton approved these changes

@josephfusco josephfusco Awaiting requested review from josephfusco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willyrk1 @tarikhamilton @bknight-masonite