Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add better container injection #84

Closed
josephmancuso opened this issue Apr 25, 2018 · 0 comments
Closed

add better container injection #84

josephmancuso opened this issue Apr 25, 2018 · 0 comments
Assignees
@josephmancuso
Labels
enhancement New feature or request
Milestone
Masonite 1.6

Comments

@josephmancuso
Copy link
Member

josephmancuso commented Apr 25, 2018 •
edited

experiment with better container injection. right now it gets all the parameters, injects them and then gets all the annotations and injects them. Try looking for a "inject in place" solution.

from masonite.requests import Request

def show(self, request: Request, Upload):
    pass

does not work. Get this to work
@josephmancuso josephmancuso added this to the Masonite 1.6 milestone Apr 25, 2018
@josephmancuso josephmancuso self-assigned this Apr 25, 2018
@josephmancuso josephmancuso added the enhancement New feature or request label Apr 25, 2018
@josephmancuso josephmancuso mentioned this issue Apr 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephmancuso josephmancuso

Labels
enhancement New feature or request
Projects
None yet
Milestone
Masonite 1.6
Development

No branches or pull requests
1 participant
@josephmancuso