Skip to content
This repository has been archived by the owner on Dec 26, 2021. It is now read-only.

Add back auth scaffolding #44

Closed
4 tasks done
josephmancuso opened this issue Feb 15, 2021 · 4 comments · Fixed by #64
Closed
4 tasks done

Add back auth scaffolding #44

josephmancuso opened this issue Feb 15, 2021 · 4 comments · Fixed by #64

Comments

@josephmancuso
Copy link
Member

josephmancuso commented Feb 15, 2021

Need to relook at all the authentication scaffolding. Early days had a lot of rewrites in this.

We need to support controllers and routes for:

  • Login
  • Registration
  • Forgot password / Password resets (possibly need a new table for this called password_resets)
  • A generic home page when the user logs in.
@josephmancuso josephmancuso added this to To do in Phase 2 - Road to Alpha via automation Feb 15, 2021
@girardinsamuel
Copy link
Contributor

Not sure why you would need a table to do password resets 🤔 ?
I guess we should stay "frontend agnostic" for the different views ? Or should we at least use Tailwind CSS ?

@josephmancuso
Copy link
Member Author

Not sure why you would need a table to do password resets

Sort of following in the foot steps of how Laravel does it. I suppose we don't really need one as we can still do it now. But I feel like it might be better to have a dedicated password resets to store the tokens. We could also better control the expirations of the token. Like password resets only valid for 24 hours or something.

@josephmancuso
Copy link
Member Author

josephmancuso commented Feb 16, 2021

I guess we should stay "frontend agnostic" for the different views ? Or should we at least use Tailwind CSS

Its a good question. I don't like being TOO opinionated on something like that. We could take a similar approach of what we did with M3 and make different presets like jinja2 (default), bootstrap, tailwind. And then have something like:

python craft auth --preset tailwind

idk if I really want to maintaining all of these upgrades though between major releases ... idk. open for discussion lol. Have to balance what would be really cool as a framework and what we want to maintain, especially going forward into M4

@girardinsamuel
Copy link
Contributor

I don't like being TOO opinionated on something like that
I agree ! I guess using the same approach would be ideal but then we would have to maintain the presets and also the auth presets and those are not really easy to maintain because there have some dependencies which are never up to date...

Maybe as Tailwind CSS seems to be used more and more and it's not a frontend framework this could be the one we will maintain for the auth scaffolding ?

For something more opiniated and complex, Laravel did Jetstream with different preset (Livewire and Inertia) but for CSS I guess they are using TailwindCSS.

@josephmancuso josephmancuso added this to the Beta milestone Feb 18, 2021
@josephmancuso josephmancuso moved this from To do to In progress in Phase 2 - Road to Alpha Feb 26, 2021
Phase 2 - Road to Alpha automation moved this from In progress to Done Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants