Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary downloads from GitHub sometimes fail, causing script to crash #14

Closed
masonr opened this issue Nov 14, 2020 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@masonr
Copy link
Owner

masonr commented Nov 14, 2020

As reported here: https://talk.lowendspirit.com/discussion/comment/45079/#Comment_45079

Preparing system for disk tests...chmod: cannot access './2020-11-13T15_19_27+08_00/disk/fio': No such file or directory

Curl command grabbing the fio binary from the github repo is failing silently, thus the chmod fails on the non-existent file.

Proposed solution:

  1. add the "--retry #" flag to the curl command to allow multiple retries to download it (in case the first try fails)
  2. add some better error handling to detect if it wasn't able to grab it for some reason and either skip the disk test (if doable) or simply alert and exit safely
@masonr masonr added the bug Something isn't working label Nov 14, 2020
@masonr masonr self-assigned this Nov 14, 2020
masonr added a commit that referenced this issue Nov 20, 2020
@masonr
Copy link
Owner Author

masonr commented Nov 20, 2020

Fixed in 203c9a0

@masonr masonr closed this as completed Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant