Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as-transform: replace 'massaExport' function calls w/underscored version. #254

Closed
0xSwapFeeder opened this issue May 22, 2023 · 0 comments · Fixed by #255
Closed

as-transform: replace 'massaExport' function calls w/underscored version. #254

0xSwapFeeder opened this issue May 22, 2023 · 0 comments · Fixed by #255
Assignees
@0xSwapFeeder
Labels
bug Something isn't working
Milestone
Smart Contract To...

Comments

@0xSwapFeeder
Copy link
Contributor

Description

At the moment, 'massaExport' decorated functions are transformed and prefixed with and underscore ('_').
The issue is, many contracts make calls with their own exported functions which will brake compilation after transform.

How to

We need a 'CallExpression' transformer that executes after the MassaExport transformer to make sure to replace them properly.
@0xSwapFeeder 0xSwapFeeder added this to the Smart Contract Tooling milestone May 22, 2023
@0xSwapFeeder 0xSwapFeeder self-assigned this May 22, 2023
@0xSwapFeeder 0xSwapFeeder added the bug Something isn't working label May 22, 2023
@0xSwapFeeder 0xSwapFeeder linked a pull request May 23, 2023 that will close this issue
Feature(as-transformer): added an MassaExport calls transformer #255
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xSwapFeeder 0xSwapFeeder

Labels
bug Something isn't working
Projects
None yet
Milestone
Smart Contract Tooling
Development

Successfully merging a pull request may close this issue.

Feature(as-transformer): added an MassaExport calls transformer massalabs/as
1 participant
@0xSwapFeeder