run test workflow at PR opening #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thykof
approved these changes
Mar 3, 2023
gregLibert
suggested changes
Mar 3, 2023
| const c = a * b; | ||
| assert(c / a == b, "SafeMath: multiplication overflow"); | ||
| const c = a * b; | ||
| assert(c / a == b, 'SafeMath: multiplication overflow'); |
There was a problem hiding this comment.
Why not doing the assert before the calculation as the others ?
Suggested change
| assert(c / a == b, 'SafeMath: multiplication overflow'); | |
| assert( b <= u64.MAX_VALUE / a, 'SafeMath: multiplication overflow'); |
| * @returns Returns the integer division of two unsigned integers. Reverts on | ||
| * division by zero. The result is rounded towards zero. | ||
| */ | ||
| static div(a: u64, b: u64): u64 { | ||
| assert(b > 0, "SafeMath: division by zero"); | ||
| const c = a / b; | ||
| assert(b > 0, 'SafeMath: division by zero'); |
There was a problem hiding this comment.
Suggested change
| assert(b > 0, 'SafeMath: division by zero'); | |
| assert(b != 0, 'SafeMath: division by zero'); |
| const c: u64 = a + b; | ||
| assert(c >= a, "SafeMath: addition overflow"); | ||
| const c: u64 = a + b; | ||
| assert(c >= a, 'SafeMath: addition overflow'); |
There was a problem hiding this comment.
should be done before the calculation
Suggested change
| assert(c >= a, 'SafeMath: addition overflow'); | |
| assert(b <= u64.MAX_VALUE - a, 'SafeMath: addition overflow'); |
Closed
|
Thanks @gregLibert for your code review, I have created a issue that reference it #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.