Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language agnostic smartcontract #243

Merged
merged 17 commits into from
May 3, 2023
Merged

Language agnostic smartcontract #243

merged 17 commits into from
May 3, 2023

Conversation

bilboquet
Copy link
Contributor

@bilboquet bilboquet commented Apr 25, 2023 •
edited
Loading

Related to #235

  • Isolate the runtime for SC written in AS (still in .wasm)
  • Introduce new language agnostic runtime with Probobuf based ABI (also .wasm). Such SC must have a byte with value 0x01 prepended
  • As consequence .wat file are not supported anymore

@bilboquet bilboquet marked this pull request as draft April 25, 2023 07:15
@bilboquet bilboquet changed the title Language agnostic smartcontract #235 Language agnostic smartcontract Apr 25, 2023
damip
damip reviewed Apr 25, 2023
View reviewed changes
build.rs

fn main() {
prost_build::compile_protos(
&["src/wasmv1_execution/abi/proto/abi.proto"],
Copy link
Member

@damip damip Apr 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should ensure that this build.rs works on mac and windows, and add documentation on any dependencies that people might need to install (eg. protoc ?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added documentation on how to install protoc into README.md
tested on Windows/Mac-Os and Ubuntu, build is ok

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make an update on massa-docs ? Especially this page: https://docs.massa.net/en/latest/testnet/install.html#from-source-code-advanced-installation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see massalabs/massa-docs#148

I kept doc minimal to avoid duplicating it.

I suggest as a followup that we move what's related to protobuf from the massa-grpc README.md (mostly copied here) into massa-docs then that we make both README.md to refer to massa-docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@damip damip mentioned this pull request Apr 25, 2023
Closed
@bilboquet bilboquet mentioned this pull request Apr 26, 2023
Closed
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch from 365ba4f to 39612f9 Compare April 27, 2023 11:09
@AurelienFT AurelienFT changed the base branch from main to testnet_22 May 2, 2023 07:17
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch from fe685be to 39becb9 Compare May 2, 2023 08:12
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch 3 times, most recently from 70c8101 to ccd4726 Compare May 2, 2023 10:12
Fix serialize/deserialize
7c0975d 
Signed-off-by: Jean-François Morcillo <jfm@massa.net>
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch from ccd4726 to 7dd769c Compare May 2, 2023 13:23
Add some ABIs
7ec63d9 
    abi_generate_event
    abi_transfer_coins
    abi_function_exists
    abi_local_call
    abi_abort
    a bit of code simplification

Signed-off-by: Jean-François Morcillo <jfm@massa.net>
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch 2 times, most recently from 220987e to 7ec63d9 Compare May 2, 2023 13:35
@bilboquet bilboquet self-assigned this May 2, 2023
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch 2 times, most recently from 5d50ff2 to 4d280cf Compare May 2, 2023 14:47
Various fix after splitting the PR
296abb8 
   remove empty file
   fix tests build
   cargo update
   cargo fmt
   fix build

Signed-off-by: Jean-François Morcillo <jfm@massa.net>
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch from 4d280cf to 296abb8 Compare May 2, 2023 14:53
Use fixed size integer in proto files
cdf266f 
Signed-off-by: Jean-François Morcillo <jfm@massa.net>
@sydhds sydhds self-requested a review May 2, 2023 15:23
Add dep to protoc in the CI
620f014 
Signed-off-by: Jean-François Morcillo <jfm@massa.net>
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch from b8b47b0 to 620f014 Compare May 2, 2023 15:33
Jean-François Morcillo added 2 commits May 2, 2023 17:41
Add documentation about protoc
16d3f62 
Signed-off-by: Jean-François Morcillo <jfm@massa.net>
fix ci
65d6145 
Signed-off-by: Jean-François Morcillo <jfm@massa.net>
@bilboquet bilboquet marked this pull request as ready for review May 2, 2023 15:49
@bilboquet bilboquet requested a review from AurelienFT May 2, 2023 15:51
This was referenced May 2, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch 3 times, most recently from e59226a to ebc0f88 Compare May 3, 2023 09:53
Fix tests that used to involve .wat files
885f16e 
Signed-off-by: Jean-François Morcillo <jfm@massa.net>
@bilboquet bilboquet force-pushed the bilboquet/issue235_language_agnostic_smartcontract branch from ebc0f88 to 885f16e Compare May 3, 2023 09:57
Fix ci/clippy
e6a3c9b 
Signed-off-by: Jean-François Morcillo <jfm@massa.net>
@bilboquet bilboquet merged commit a7caf34 into testnet_22 May 3, 2023
@bors bors bot deleted the bilboquet/issue235_language_agnostic_smartcontract branch May 3, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip left review comments

@sydhds sydhds sydhds approved these changes

@AurelienFT AurelienFT Awaiting requested review from AurelienFT

Assignees

@bilboquet bilboquet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bilboquet @sydhds @damip