Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Gather infos from abis #327

Merged
merged 17 commits into from
Feb 22, 2024
Merged

Feature/Gather infos from abis #327

merged 17 commits into from
Feb 22, 2024

Conversation

AurelienFT
Copy link
Member

No description provided.

AurelienFT
AurelienFT commented Feb 20, 2024
View reviewed changes
Copy link
Member Author

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good job. Few little comments

src/as_execution/abi.rs Show resolved Hide resolved
src/as_execution/abi.rs Outdated Show resolved Hide resolved
src/as_execution/abi.rs Outdated Show resolved Hide resolved
src/as_execution/abi.rs Show resolved Hide resolved
src/types.rs Show resolved Hide resolved
@AurelienFT AurelienFT marked this pull request as ready for review February 20, 2024 13:21
bilboquet
bilboquet previously approved these changes Feb 20, 2024
View reviewed changes
bilboquet
bilboquet previously approved these changes Feb 22, 2024
View reviewed changes
@AurelienFT
Copy link
Member Author

I merge as an approve just i'm the PR creator that's why I can't approve

Leo-Besancon
Leo-Besancon approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for Aurelien

@AurelienFT AurelienFT added this pull request to the merge queue Feb 22, 2024
@AurelienFT
Copy link
Member Author

Léo approve's is only to impersonate me.

@AurelienFT AurelienFT changed the title Feature/draft gather infos aurelien Feature/draft gather infos from abis Feb 22, 2024
@AurelienFT AurelienFT changed the title Feature/draft gather infos from abis Feature/Gather infos from abis Feb 22, 2024
Merged via the queue into main with commit 3210281 Feb 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydhds sydhds sydhds left review comments

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@bilboquet bilboquet bilboquet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AurelienFT @sydhds @bilboquet @Leo-Besancon