Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proto-cli): added custom type fetching #324

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

0xSwapFeeder
Copy link
Contributor

Also added custom type object when "custom_type" decorator is found

@0xSwapFeeder 0xSwapFeeder self-assigned this Jul 31, 2023
@0xSwapFeeder
Copy link
Contributor Author

CI broken, omw to fix it, don't merge

Copy link
Contributor

@bilboquet bilboquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to see some tests includes?

Edit:
Ok, seems tests are part of another PR, gonna approve so we can keep going

@bilboquet
Copy link
Contributor

bors merge

@bors
Copy link

bors bot commented Aug 3, 2023

Configuration problem:
bors.toml: not found

@bilboquet
Copy link
Contributor

Configuration problem: bors.toml: not found

no luck…
I don't know how to merge and it seems I don't have on this repo

@Ben-Rey please see if you can merge

@Ben-Rey Ben-Rey merged commit 7c34c49 into main Aug 3, 2023
2 of 3 checks passed
@Ben-Rey Ben-Rey deleted the feature/custom-type-fetching branch August 3, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants