Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests improvements #4418

Open
4 tasks
AurelienFT opened this issue Sep 20, 2023 · 2 comments · Fixed by #4423 or #4441
Open
4 tasks

Unit tests improvements #4418

AurelienFT opened this issue Sep 20, 2023 · 2 comments · Fixed by #4423 or #4441
Assignees
Labels
global Issue that concern the whole codebase tests Issues related to testing the node

Comments

@AurelienFT
Copy link
Member

AurelienFT commented Sep 20, 2023

Context

The goal is to ensure security in the node before mainnet release. We want to improve the unit test base to help us achieve this goal. There is a list of criteria that we want to validate :

  • 80% of the code tested and all in the sub crates (All coverage is calculated using cargo-llvm-cov)
  • Tests to ensure all low limit and high limit of serializer/deserializer are tested

Current test coverage on the whole project : 44.61% (Update: 20/09/2023) (without bootstrap as it's impossible to run tarpaulin with the bootstrap test)

I will update the issue module by module :

massa-api

Managed by @modship and @aoudiamoncef

massa async pool

Actual code coverage

11,69 % (Updated : 20/09/2023) (command used cargo llvm-cov test --open --package massa_async_pool --features testing --ignore-filename-regex "(massa-models)|(massa-hash)|(massa-time)|(massa-signature)|(massa-ledger-exports)|(massa-serialization)")

  • Serializers and deserializers limits tested

massa-bootstrap

Managed by @Leo-Besancon and @litchipi

massa-client

@damip we skip this, no ?

massa-cipher

0,00 % (Updated : 20/09/2023) (command used cargo llvm-cov test --open --package massa_cipher --ignore-filename-regex "(massa-models)|(massa-hash)|(massa-time)|(massa-signature)|(massa-ledger-exports)|(massa-serialization)")

massa-consensus-worker

58,27 % (Updated: 20/09/2023) (command used cargo llvm-cov test --open --package massa_consensus_worker --features testing --ignore-filename-regex "(massa-models)|(massa-hash)|(massa-time)|(massa-signature)|(massa-ledger-exports)|(massa-serialization)|(massa-consensus-exports)|(massa-channel)|(massa-async-pool)|(massa-db-exports)|(massa-executed-ops)|(massa-execution-exports)|(massa-final-state)|(massa-metrics)|(massa-module-cache)|(massa-pool-exports)|(massa-protocol-exports)|(massa-pos-exports)|(massa-storage)|(massa-versioning)")

  • Serializers and deserializers limits tested

massa-db-worker

0,00 % (Updated: 20/09/2023) (command used cargo llvm-cov test --open --package massa_db_worker --ignore-filename-regex "(massa-models)|(massa-hash)|(massa-time)|(massa-signature)|(massa-ledger-exports)|(massa-serialization)|(massa-consensus-exports)|(massa-channel)|(massa-async-pool)|(massa-db-exports)|(massa-executed-ops)|(massa-execution-exports)|(massa-final-state)|(massa-metrics)|(massa-module-cache)|(massa-pool-exports)|(massa-protocol-exports)|(massa-pos-exports)|(massa-storage)|(massa-versioning)")

  • Serializers and deserializers limits tested

massa-executed-ops

0,00% (Updated: 20/09/2023) (command used cargo llvm-cov test --open --package massa_executed_ops --ignore-filename-regex "(massa-models)|(massa-hash)|(massa-time)|(massa-signature)|(massa-ledger-exports)|(massa-serialization)|(massa-consensus-exports)|(massa-channel)|(massa-async-pool)|(massa-db-exports)|(massa-execution-exports)|(massa-final-state)|(massa-metrics)|(massa-module-cache)|(massa-pool-exports)|(massa-protocol-exports)|(massa-pos-exports)|(massa-storage)|(massa-versioning)" )

  • Serializers and deserializers limits tested
@damip
Copy link
Member

damip commented Sep 20, 2023

Yes we can skip the client for now :)

@modship modship linked a pull request Sep 22, 2023 that will close this issue
8 tasks
@sydhds sydhds self-assigned this Sep 29, 2023
@sydhds sydhds linked a pull request Oct 2, 2023 that will close this issue
8 tasks
@AurelienFT AurelienFT reopened this Oct 9, 2023
@litchipi
Copy link
Contributor

litchipi commented Oct 9, 2023

Tests improvements on the bootstrap: #4454

@Leo-Besancon Leo-Besancon reopened this Oct 9, 2023
@AurelienFT AurelienFT added tests Issues related to testing the node global Issue that concern the whole codebase labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
global Issue that concern the whole codebase tests Issues related to testing the node
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants