Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests grpc public api #4423

Merged
merged 41 commits into from
Oct 9, 2023
Merged

Tests grpc public api #4423

merged 41 commits into from
Oct 9, 2023

Conversation

modship
Copy link
Member

@modship modship commented Sep 22, 2023 •
edited

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

🚫 send_blocks has been disabled

Code coverage :
image

This was linked to issues Sep 22, 2023
Node security meta-issue #4415
Open
Unit tests improvements #4418
Open
@modship modship linked an issue Sep 25, 2023 that may be closed by this pull request
API unit tests #4426
Closed
70 tasks
@modship modship mentioned this pull request Sep 26, 2023
Closed
aoudiamoncef
aoudiamoncef suggested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@aoudiamoncef aoudiamoncef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the PR did what It should done. GG

If we refactor the code little bit, we'll have a great tests

aoudiamoncef

This comment was marked as duplicate.

Sign in to view

aoudiamoncef

This comment was marked as duplicate.

Sign in to view

aoudiamoncef
aoudiamoncef approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@aoudiamoncef aoudiamoncef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work 👍🏻

@modship
Copy link
Member Author

modship commented Oct 9, 2023

bors merge

@modship modship mentioned this pull request Oct 9, 2023
Closed
70 tasks
@bors
Copy link
Contributor

bors bot commented Oct 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@modship modship merged commit b9a93dc into main Oct 9, 2023
12 checks passed
@AurelienFT AurelienFT deleted the grpc_tests branch October 23, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoudiamoncef aoudiamoncef aoudiamoncef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests improvements Node security meta-issue API unit tests
2 participants
@modship @aoudiamoncef