Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests on coin spending edge cases #4501

Closed
17 of 25 tasks
Leo-Besancon opened this issue Oct 26, 2023 · 0 comments · Fixed by #4532
Closed
17 of 25 tasks

add unit tests on coin spending edge cases #4501

Leo-Besancon opened this issue Oct 26, 2023 · 0 comments · Fixed by #4532
Assignees

Comments

@Leo-Besancon
Copy link
Contributor

Leo-Besancon commented Oct 26, 2023

  • List all coin spending cases (all op types, during sc creation)
  • Test each one

execution.rs

  • Fee debit
  • Roll Buy
  • exec transaction op
  • exec call sc op
  • exec async message
  • Credit creator of the endorsement
  • credit creator of the endorsed block
  • credit block creator with remaining_credit
  • transfert fee (read only bytecode)
  • transfert fee (read only function call)
  • transfert coins (read only function call)

context.rs

  • cancel_async_message
  • execute_deferred_credits

interface_impl.rs

  • init_call transfer coins from caller to target
  • transfer_coins /// [DeprecatedByNewRuntime] Replaced by transfer_coins_wasmv1
  • transfer_coins_for //Transfer coins from a given address towards a target address.
  • transfer_coins_wasmv1 // Transfer coins from a given address (or the current address if not specified) towards a target address.
  • send_message coins + fee //asynchronous message to the context speculative asynchronous pool
  • init_call_wasmv1 //transfer coins from caller to target address

speculative_ledger.rs

  • transfer_coins
  • create_new_sc_address
  • set_bytecode
  • charge_datastore_entry_change_storage
@modship modship linked a pull request Nov 13, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants