coins spending tests #4532

modship · 2023-11-13T09:32:29Z

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

* Use a controller for final state to be able to mock it * Fix all formatting issues. * Use more mocks in execution tests * Fix test nested call usage * improve some tests execution * Fix tests async message and compact the test of executed * Fix more execution tests * Fix more tests. * Update more tests * Finish fixing all executions tests. * Improve naming * add more comment * Fix comment

damip · 2023-11-21T10:57:09Z

@modship can you rebase it on main ?

# Conflicts: # massa-bootstrap/src/tests/scenarios.rs # massa-execution-worker/src/interface_impl.rs # massa-execution-worker/src/tests/scenarios_mandatories.rs # massa-final-state/src/test_exports/mock.rs

* Add some unit tests for versioning deserialization to the limits * Clippy pass * Better error message * Minor fixes * Excluded -> Included --------- Co-authored-by: sydhds <sydhds@gmail.com>

* Add versioninig key & value checks * Improve error message when no prefix --------- Co-authored-by: sydhds <sydhds@gmail.com>

…_tests

codecov · 2023-11-28T09:18:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (pre_mainnet_wip@77f33a0). Click here to learn what that means.

Additional details and impacted files

@@                Coverage Diff                 @@
##             pre_mainnet_wip    #4532   +/-   ##
==================================================
  Coverage                   ?   72.55%           
==================================================
  Files                      ?      288           
  Lines                      ?    50874           
  Branches                   ?        0           
==================================================
  Hits                       ?    36910           
  Misses                     ?    13964           
  Partials                   ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bilboquet

looks good to me

* Update version & CI * Test/array indexing checkup 1 (#4560) * Update ci.yml * Feature/feature/versioning ser der harden 2 (#4554) * Add some unit tests for versioning deserialization to the limits * Clippy pass * Better error message * Minor fixes * Excluded -> Included --------- Co-authored-by: sydhds <sydhds@gmail.com> * Add versioninig key & value checks (#4552) * Add versioninig key & value checks * Improve error message when no prefix --------- Co-authored-by: sydhds <sydhds@gmail.com> * Update CI, Version and genesis timestamp * Add array indexing listing tool * Remove array indexing in denunciation code * Remove more array indexing * Add more exclude patterns * Use nom take --------- Co-authored-by: sydhds <sydhds@gmail.com> * Fails in send_operations if get_gas_usage() > max_gas_per_block Returning a distinct error message for ExecuteSC and CallSC operations. Signed-off-by: Jean-François <jfm@laposte.net> * coins spending tests (#4532) * Buildnet WIP * Mock Final State/Improve tests execution (#4512) * Use a controller for final state to be able to mock it * Fix all formatting issues. * Use more mocks in execution tests * Fix test nested call usage * improve some tests execution * Fix tests async message and compact the test of executed * Fix more execution tests * Fix more tests. * Update more tests * Finish fixing all executions tests. * Improve naming * add more comment * Fix comment * update test to check spend coins with readonly * add coins * check coins on rollbuy * clippy * update roll_buy * delete helloworld wasm * update test_readonly_execution * fix tests merge * fix test test_readonly_execution * Update ci.yml * Feature/feature/versioning ser der harden 2 (#4554) * Add some unit tests for versioning deserialization to the limits * Clippy pass * Better error message * Minor fixes * Excluded -> Included --------- Co-authored-by: sydhds <sydhds@gmail.com> * Add versioninig key & value checks (#4552) * Add versioninig key & value checks * Improve error message when no prefix --------- Co-authored-by: sydhds <sydhds@gmail.com> * Update CI, Version and genesis timestamp * add test for cancel_async_msg * clippy * cancel async msg check refound sender --------- Co-authored-by: Leo-Besancon <lb@massa.net> Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * improve errors (#4567) * tech(async_msg) : check if the target address exist * tech(call_sc) : add check target address to call_sc_op * check target sc address on init_call * check target address in read only call * fix unit tests * remove dbg macro * Update massa-execution-worker/src/context.rs Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> --------- Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> * Fix tests (#4568) * Fix CI WIP (#4569) * Fix ws_disabled() test on windows * fix bootstrap server port * Fix CI local Leo * Update scenarios_mandatories.rs * Add CI profile argument to nextest --------- Co-authored-by: modship <yeskinokay@gmail.com> * Fix test + Update lcov.info * Add codecov.yml * fix internal error serde (#4570) * Release prebuilt profile (#4572) * codegen-units set to 1 for prebuilt binaries * Update toolchain version in CI & CD * Update CI & Genesis --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net> Co-authored-by: Modship <yeskinokay@gmail.com> Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>

Leo-Besancon and others added 3 commits November 8, 2023 16:06

Buildnet WIP

ff22cfd

update test to check spend coins with readonly

6b5e440

modship linked an issue Nov 13, 2023 that may be closed by this pull request

add unit tests on coin spending edge cases #4501

Closed

25 tasks

modship changed the title ~~update test to check spend coins with readonly~~ coins spending tests Nov 13, 2023

modship added 4 commits November 13, 2023 10:38

add coins

f7e76b2

check coins on rollbuy

3aafe92

clippy

8e2e3da

update roll_buy

e616995

Leo-Besancon mentioned this pull request Nov 13, 2023

Node security meta-issue #4415

Open

45 tasks

modship added 2 commits November 13, 2023 11:38

delete helloworld wasm

a828db9

update test_readonly_execution

b895efa

modship added 3 commits November 21, 2023 14:20

Merge branch 'main' into coins_spending_tests

9b82d65

# Conflicts: # massa-bootstrap/src/tests/scenarios.rs # massa-execution-worker/src/interface_impl.rs # massa-execution-worker/src/tests/scenarios_mandatories.rs # massa-final-state/src/test_exports/mock.rs

fix tests merge

21e8c51

fix test test_readonly_execution

48239d3

modship changed the base branch from buildnet_wip to main November 22, 2023 08:21

Leo-Besancon changed the base branch from main to pre_mainnet November 22, 2023 08:36

Leo-Besancon and others added 3 commits November 27, 2023 13:31

Update ci.yml

8703512

Feature/feature/versioning ser der harden 2 (#4554)

b1532d8

* Add some unit tests for versioning deserialization to the limits * Clippy pass * Better error message * Minor fixes * Excluded -> Included --------- Co-authored-by: sydhds <sydhds@gmail.com>

Add versioninig key & value checks (#4552)

1a0c597

* Add versioninig key & value checks * Improve error message when no prefix --------- Co-authored-by: sydhds <sydhds@gmail.com>

Leo-Besancon force-pushed the pre_mainnet branch from bc7d554 to 1a0c597 Compare November 27, 2023 12:31

Leo-Besancon and others added 4 commits November 27, 2023 13:40

Update CI, Version and genesis timestamp

4b76fbc

add test for cancel_async_msg

2a761a7

clippy

ed3319b

cancel async msg check refound sender

aa082ca

modship marked this pull request as ready for review November 28, 2023 08:29

Merge remote-tracking branch 'origin/pre_mainnet' into coins_spending…

085dbba

…_tests

Base automatically changed from pre_mainnet to main November 28, 2023 08:34

Leo-Besancon changed the base branch from main to pre_mainnet_wip November 28, 2023 08:40

modship requested a review from Leo-Besancon November 28, 2023 08:42

Merge branch 'pre_mainnet_wip' into coins_spending_tests

fc17364

modship requested a review from bilboquet November 28, 2023 09:11

bilboquet approved these changes Nov 28, 2023

View reviewed changes

damip merged commit a4920d4 into pre_mainnet_wip Nov 28, 2023
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

coins spending tests #4532

coins spending tests #4532

modship commented Nov 13, 2023

damip commented Nov 21, 2023

codecov bot commented Nov 28, 2023

bilboquet left a comment

coins spending tests #4532

coins spending tests #4532

Conversation

modship commented Nov 13, 2023

damip commented Nov 21, 2023

codecov bot commented Nov 28, 2023

Codecov Report

bilboquet left a comment

Choose a reason for hiding this comment