Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize crate name with massa_ prefix #1920

Merged
merged 1 commit into from Dec 9, 2021
Merged

Standardize crate name with massa_ prefix #1920

merged 1 commit into from Dec 9, 2021

Conversation

yvan-sraka
Copy link
Contributor

No description provided.

@yvan-sraka yvan-sraka self-assigned this Dec 6, 2021
@yvan-sraka yvan-sraka force-pushed the standardize-crate-names branch 2 times, most recently from d79e26b to 43344bc Compare December 6, 2021 08:31
@yvan-sraka yvan-sraka marked this pull request as draft December 6, 2021 08:33
AureliaDolo
AureliaDolo reviewed Dec 6, 2021
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@yvan-sraka yvan-sraka mentioned this pull request Dec 6, 2021
Closed
@yvan-sraka yvan-sraka marked this pull request as ready for review December 6, 2021 09:25
@AureliaDolo AureliaDolo self-requested a review December 6, 2021 09:53
AureliaDolo
AureliaDolo suggested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@AureliaDolo AureliaDolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doctests are not ok

AureliaDolo
AureliaDolo reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@AureliaDolo AureliaDolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite not sure about removing indentations in config.toml

@adrien-zinger
Copy link
Contributor

image

"when everyone's massa, no one will be" - Syndrom

@AureliaDolo
Copy link
Contributor

Oh no, conflicts ⚔️

@yvan-sraka
Copy link
Contributor Author

I will wait for #1848 to be merged first in intend of not playing solving conflict twice!

@AureliaDolo
Copy link
Contributor

I will wait for #1848 to be merged first in intend of not playing solving conflict twice!

What's the link with #1848 ?

@AureliaDolo AureliaDolo added the blocked Issues that can't be done for now. label Dec 7, 2021
@AureliaDolo
Copy link
Contributor

@yvan-sraka aaand conflicts (and failed doc tests) 😢

@yvan-sraka yvan-sraka removed the blocked Issues that can't be done for now. label Dec 8, 2021
@yvan-sraka
Copy link
Contributor Author

Doctests are not ok

@AureliaDolo solved!

AureliaDolo
AureliaDolo previously approved these changes Dec 8, 2021
View reviewed changes
bors bot added a commit that referenced this pull request Dec 8, 2021
@bors @yvan-sraka
Merge #1920
7d473a1 
1920: Standardize crate name with `massa_` prefix r=yvan-sraka a=yvan-sraka



Co-authored-by: Yvan Sraka <yvan@sraka.xyz>
@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Build failed:

adrien-zinger
adrien-zinger previously approved these changes Dec 8, 2021
View reviewed changes
@yvan-sraka yvan-sraka force-pushed the standardize-crate-names branch 2 times, most recently from f7dca29 to 39f4648 Compare December 8, 2021 16:48
adrien-zinger
adrien-zinger previously approved these changes Dec 8, 2021
View reviewed changes
@yvan-sraka
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Merge conflict.

adrien-zinger
adrien-zinger previously approved these changes Dec 8, 2021
View reviewed changes
@yvan-sraka
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 8, 2021
@bors @yvan-sraka
Merge #1920
2d2f9a5 
1920: Standardize crate name with `massa_` prefix r=yvan-sraka a=yvan-sraka



Co-authored-by: Yvan Sraka <yvan@sraka.xyz>
@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Build failed:

@yvan-sraka
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 9, 2021

Build succeeded:

@bors bors bot merged commit 03269f6 into main Dec 9, 2021
@bors bors bot deleted the standardize-crate-names branch December 9, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureliaDolo AureliaDolo AureliaDolo approved these changes

@damip damip Awaiting requested review from damip

@adrien-zinger adrien-zinger Awaiting requested review from adrien-zinger

Assignees

@yvan-sraka yvan-sraka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yvan-sraka @adrien-zinger @AureliaDolo