Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct tests #2054

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Correct tests #2054

merged 3 commits into from
Dec 30, 2021

Conversation

damip
Copy link
Member

@damip damip commented Dec 30, 2021

Corrected tests by taking into account the initial time

@damip damip changed the base branch from main to feature/execution/add_cautious_bassoon December 30, 2021 14:09
@damip damip added the bug Something isn't working label Dec 30, 2021
@damip damip added this to the TEST.6.0 milestone Dec 30, 2021
@damip damip linked an issue Dec 30, 2021 that may be closed by this pull request
cargo test fail on macOS in CI with a timeout error #1826
Closed
yvan-sraka
yvan-sraka approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@yvan-sraka yvan-sraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvan-sraka
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Dec 30, 2021
@bors @damip
Merge #2054
d77c49c 
2054: Correct tests r=yvan-sraka a=damip

Corrected tests by taking into account the initial time

Co-authored-by: damip <damipator@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build failed:

@damip
Copy link
Member Author

damip commented Dec 30, 2021

bors merge

bors bot added a commit that referenced this pull request Dec 30, 2021
@bors @damip
Merge #2054
bca9211 
2054: Correct tests r=damip a=damip

Corrected tests by taking into account the initial time

Co-authored-by: damip <damipator@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build failed:

@damip
Copy link
Member Author

damip commented Dec 30, 2021

bors merge

bors bot added a commit that referenced this pull request Dec 30, 2021
@bors @damip
Merge #2054
9a588ce 
2054: Correct tests r=damip a=damip

Corrected tests by taking into account the initial time

Co-authored-by: damip <damipator@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build failed:

@adrien-zinger
Only test stop_node if feature local activated
3d45d65 
The scenario stop_node is really unstable for the moment because it
touch unstable topics as *config management* and *test environment*. For
the moment the test should be only be ran manually by a user with a
command line:

```bash
cargo test --package massa_client --lib --all-features -- tests::scenarios::test_run_node --exact --nocapture
```
@adrien-zinger
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build succeeded:

@bors bors bot merged commit 7adf8cb into feature/execution/add_cautious_bassoon Dec 30, 2021
@bors bors bot deleted the correct_tests branch December 30, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvan-sraka yvan-sraka yvan-sraka approved these changes

@adrien-zinger adrien-zinger adrien-zinger approved these changes

Assignees

@damip damip

Labels
bug Something isn't working
Projects
None yet
Milestone
TEST.6.0
Development

Successfully merging this pull request may close these issues.

cargo test fail on macOS in CI with a timeout error
3 participants
@damip @yvan-sraka @adrien-zinger