Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storage perf in Execution #3077

Merged
merged 21 commits into from
Oct 3, 2022
Merged

Conversation

damip
Copy link
Member

@damip damip commented Sep 26, 2022

This PR aims at massively improving the performance of Execution.

  • document all added functions
  • try in sandbox/simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • add comments and docs

@damip damip self-assigned this Sep 27, 2022
@damip damip added this to the TEST.15.X milestone Sep 27, 2022
@damip damip marked this pull request as ready for review September 27, 2022 12:59
Copy link
Member

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand in details the slot sequencer so I don't know if there is errors. For the rest it seems ok.

massa-execution-worker/src/controller.rs Show resolved Hide resolved
massa-execution-worker/src/execution.rs Show resolved Hide resolved
@damip
Copy link
Member Author

damip commented Sep 28, 2022

I don't understand in details the slot sequencer so I don't know if there is errors. For the rest it seems ok.

That means that I need to write the document explaining the algorithm. I'm on it

@damip
Copy link
Member Author

damip commented Sep 29, 2022

I don't understand in details the slot sequencer so I don't know if there is errors. For the rest it seems ok.

Should be clearer now

Copy link
Member

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slot sequencer is very well documented and explicit even if it's big. If it has been tested in real conditions it's ok for me.

@damip
Copy link
Member Author

damip commented Oct 3, 2022

bors merge

bors bot added a commit that referenced this pull request Oct 3, 2022
3077: Improve storage perf in Execution r=damip a=damip

This PR aims at massively improving the performance of Execution.

* [x] document all added functions
* [x] try in sandbox/simulation/labnet
* [x] unit tests on the added/changed features
  * [x] make tests compile
  * [x] make tests pass 
* [x] add logs allowing easy debugging in case the changes caused problems
* [x] add comments and docs

Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 3, 2022

Build failed:

@damip
Copy link
Member Author

damip commented Oct 3, 2022

bors merge

bors bot added a commit that referenced this pull request Oct 3, 2022
3077: Improve storage perf in Execution r=damip a=damip

This PR aims at massively improving the performance of Execution.

* [x] document all added functions
* [x] try in sandbox/simulation/labnet
* [x] unit tests on the added/changed features
  * [x] make tests compile
  * [x] make tests pass 
* [x] add logs allowing easy debugging in case the changes caused problems
* [x] add comments and docs

Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 3, 2022

Build failed:

@damip
Copy link
Member Author

damip commented Oct 3, 2022

bors merge

bors bot added a commit that referenced this pull request Oct 3, 2022
3077: Improve storage perf in Execution r=damip a=damip

This PR aims at massively improving the performance of Execution.

* [x] document all added functions
* [x] try in sandbox/simulation/labnet
* [x] unit tests on the added/changed features
  * [x] make tests compile
  * [x] make tests pass 
* [x] add logs allowing easy debugging in case the changes caused problems
* [x] add comments and docs

Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@damip damip merged commit 54e280f into prepare_testnet_15 Oct 3, 2022
@bors
Copy link
Contributor

bors bot commented Oct 3, 2022

Build failed:

@AurelienFT AurelienFT deleted the storage_perf_in_exec branch May 29, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants