-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve storage perf in Execution #3077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand in details the slot sequencer so I don't know if there is errors. For the rest it seems ok.
That means that I need to write the document explaining the algorithm. I'm on it |
Should be clearer now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slot sequencer is very well documented and explicit even if it's big. If it has been tested in real conditions it's ok for me.
bors merge |
3077: Improve storage perf in Execution r=damip a=damip This PR aims at massively improving the performance of Execution. * [x] document all added functions * [x] try in sandbox/simulation/labnet * [x] unit tests on the added/changed features * [x] make tests compile * [x] make tests pass * [x] add logs allowing easy debugging in case the changes caused problems * [x] add comments and docs Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Build failed: |
bors merge |
3077: Improve storage perf in Execution r=damip a=damip This PR aims at massively improving the performance of Execution. * [x] document all added functions * [x] try in sandbox/simulation/labnet * [x] unit tests on the added/changed features * [x] make tests compile * [x] make tests pass * [x] add logs allowing easy debugging in case the changes caused problems * [x] add comments and docs Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Build failed: |
bors merge |
3077: Improve storage perf in Execution r=damip a=damip This PR aims at massively improving the performance of Execution. * [x] document all added functions * [x] try in sandbox/simulation/labnet * [x] unit tests on the added/changed features * [x] make tests compile * [x] make tests pass * [x] add logs allowing easy debugging in case the changes caused problems * [x] add comments and docs Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Build failed: |
This PR aims at massively improving the performance of Execution.