List required active blocks refactoring #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Eitu33
commented
Dec 6, 2022
•
Eitu33
commented
- document all added functions
- try in labnet
- make tests compile
- make tests pass
- add logs allowing easy debugging in case the changes caused problems
AurelienFT
previously approved these changes
Dec 6, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Dec 6, 2022
3310: List required active blocks refactoring r=AurelienFT a=Eitu33 * [x] document all added functions * [x] try in labnet * [x] make tests compile * [x] make tests pass * [x] add logs allowing easy debugging in case the changes caused problems Co-authored-by: Thomas Plisson <thomas.plisson@epitech.eu>
|
Build failed: |
|
The bootstrap test fails in the CI |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Dec 7, 2022
3310: List required active blocks refactoring r=AurelienFT a=Eitu33 * [x] document all added functions * [x] try in labnet * [x] make tests compile * [x] make tests pass * [x] add logs allowing easy debugging in case the changes caused problems Co-authored-by: Thomas Plisson <thomas.plisson@epitech.eu>
|
that's strange that it fails sometimes, we already saw this error on a precedent PR but don't have any bug on the testnet similar :/ |
|
Build failed: |
|
It does consistently fail. We should investigate |
Yes ! |
AurelienFT
approved these changes
Dec 7, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.