Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testnet 20 #3489

Merged
merged 88 commits into from Mar 1, 2023
Merged

Testnet 20 #3489

merged 88 commits into from Mar 1, 2023

Conversation

@AurelienFT AurelienFT marked this pull request as draft February 1, 2023 14:38
@AurelienFT AurelienFT changed the base branch from main to testnet_19 February 1, 2023 14:38
@AurelienFT AurelienFT changed the base branch from testnet_19 to main February 2, 2023 10:17
@damip
Copy link
Member

damip commented Feb 4, 2023

Don't forget to remove the artificial minor-version incompatibility added between 19.0 and 19.1

Ben-PH and others added 15 commits February 6, 2023 15:46
* Add BlockDeserializerArgs struct & parents struct

* Use substruct proc macro

* Code cleanup

* Code cleanup (round 2)

* Update doctests

* Update substruct dependency

* Remove useless import

* Remove dead code

---------

Co-authored-by: sydhds <sd@massa.net>
* Update sandbox version

* Fix sandbox minor version

* Update version check

* Update massa-models/src/version.rs

Co-authored-by: Eitu33 <89928840+Eitu33@users.noreply.github.com>

---------

Co-authored-by: sydhds <sd@massa.net>
Co-authored-by: Eitu33 <89928840+Eitu33@users.noreply.github.com>
@modship modship mentioned this pull request Mar 21, 2023
@damip
Copy link
Member

damip commented Mar 21, 2023

Question: is MAX_OPERATIONS_PER_BLOCK checked when we receive the operations of the block ? looks like we only check their total size (?)

@damip
Copy link
Member

damip commented Mar 21, 2023

Question: is MAX_OPERATIONS_PER_BLOCK checked when we receive the operations of the block ? looks like we only check their total size (?)

Encompassing issue: #3709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet