Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper error result in MipStoreRaw::update_with(..) function #3906

Merged
merged 3 commits into from
May 5, 2023
Merged

Add proper error result in MipStoreRaw::update_with(..) function #3906

merged 3 commits into from
May 5, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented May 4, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested review from Eitu33 and Leo-Besancon May 4, 2023 14:13
@sydhds sydhds changed the base branch from testnet_22 to testnet_23 May 4, 2023 14:59
Eitu33
Eitu33 approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@Eitu33 Eitu33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@sydhds sydhds requested a review from Leo-Besancon May 5, 2023 09:48
@sydhds sydhds mentioned this pull request May 5, 2023
Open
18 tasks
Leo-Besancon
Leo-Besancon approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for the docs improvement

@sydhds sydhds merged commit 9a878ce into testnet_23 May 5, 2023
11 checks passed
@sydhds sydhds deleted the feature/versioning_update_with_better_error branch May 5, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@Eitu33 Eitu33 Eitu33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sydhds @Leo-Besancon @Eitu33