Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid [] access #3984

Merged
merged 5 commits into from
May 25, 2023
Merged

avoid [] access #3984

merged 5 commits into from
May 25, 2023

Conversation

modship
Copy link
Member

@modship modship commented May 25, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

close #3962

@modship modship requested a review from AurelienFT May 25, 2023 13:33
@AurelienFT AurelienFT mentioned this pull request May 25, 2023
Closed
@modship modship merged commit 9e5c747 into testnet_23 May 25, 2023
10 checks passed
@AurelienFT AurelienFT deleted the avoid_array_access branch May 29, 2023 09:42
@Ben-PH Ben-PH mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@modship @AurelienFT