Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change MassaTime::from to MassaTime::from_millis #3986

Merged
merged 9 commits into from
May 26, 2023
Merged

change MassaTime::from to MassaTime::from_millis #3986

merged 9 commits into from
May 26, 2023

Conversation

modship
Copy link
Member

@modship modship commented May 26, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship linked an issue May 26, 2023 that may be closed by this pull request
Change MassaTime::from into MassaTime::from_millis #3649
Closed
AurelienFT
AurelienFT reviewed May 26, 2023
View reviewed changes
massa-time/src/lib.rs Outdated Show resolved Hide resolved
@AurelienFT
Copy link
Member

I will fix the CI on testnet_23

@modship
Copy link
Member Author

modship commented May 26, 2023

I will fix the CI on testnet_23
😍

AurelienFT
AurelienFT approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this rectoring

@modship modship merged commit 043eb49 into testnet_23 May 26, 2023
10 checks passed
@AurelienFT AurelienFT deleted the massa_time_from_ms branch May 29, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change MassaTime::from into MassaTime::from_millis
2 participants
@modship @AurelienFT