Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix massa client without grpc #3999

Merged
merged 2 commits into from
May 30, 2023
Merged

fix massa client without grpc #3999

merged 2 commits into from
May 30, 2023

Conversation

modship
Copy link
Member

@modship modship commented May 29, 2023 •
edited

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

close #3998

@modship modship requested a review from aoudiamoncef May 29, 2023 15:52
@modship modship linked an issue May 29, 2023 that may be closed by this pull request
massa-client crash on startup #3998
Closed
aoudiamoncef
aoudiamoncef approved these changes May 29, 2023
View reviewed changes
massa-sdk/src/lib.rs Outdated
{
Ok(channel) => Some(MassaServiceClient::new(channel)),
Err(_e) => {
// TODO print error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could write a small warning here "gRPC is not enabled"

massa-client/src/cmds.rs Outdated Show resolved Hide resolved
@modship modship merged commit 09227d6 into testnet_23 May 30, 2023
10 checks passed
@modship modship deleted the fix/massa_client_grpc branch May 30, 2023 07:54
@modship modship mentioned this pull request May 31, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoudiamoncef aoudiamoncef aoudiamoncef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

massa-client crash on startup
2 participants
@modship @aoudiamoncef