4012 remove dependency to chrono #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Leo-Besancon
commented
Jun 1, 2023
Leo-Besancon
commented
- document all added functions
- try in sandbox /simulation/labnet
- unit tests on the added/changed features
- make tests compile
- make tests pass
- add logs allowing easy debugging in case the changes caused problems
- if the API has changed, update the API specification
damip
reviewed
Jun 1, 2023
massa-bootstrap/src/client.rs
Outdated
| .unwrap(); | ||
| warn!("Please update your Massa node before: {}", dt.to_rfc2822()); | ||
|
|
||
| let activation_datetime = OffsetDateTime::from_unix_timestamp( |
There was a problem hiding this comment.
I vote for encapsulating all time related stuff into MassaTime.
So basically we can have "MassaTime::format_instant" and a "MassaTime::format_duration" methods
There was a problem hiding this comment.
Done in f0c9d7e
damip
reviewed
Jun 1, 2023
massa-versioning/src/versioning.rs
Outdated
| start: MassaTime::from_millis(start.timestamp() as u64), | ||
| timeout: MassaTime::from_millis(timeout.timestamp() as u64), | ||
| start: MassaTime::from_millis( | ||
| start_datetime |
There was a problem hiding this comment.
we should use MassaTime everywhere. Why are we using NaiveDateTime and OffsetDateTime at all ?
There was a problem hiding this comment.
Changed to MassaTime in f0c9d7e
sydhds
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.