add better tests protocol #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modship
reviewed
Oct 10, 2023
Leo-Besancon
requested review from
sydhds
and removed request for
Leo-Besancon
modship
previously approved these changes
Oct 10, 2023
modship
previously approved these changes
Oct 10, 2023
sydhds
requested changes
Oct 11, 2023
modship
approved these changes
Oct 12, 2023
sydhds
approved these changes
Oct 12, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 13, 2023
4461: add better tests protocol r=AurelienFT a=AurelienFT This PR add : - Tests on deserializers/serializers that measures lengths. - Tests on handshake - Remove the messages handlers fields from the `MassaHandshake` which was a duplicate Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add :
MassaHandshakewhich was a duplicate