Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test: send coins #807

Merged
merged 8 commits into from
Nov 2, 2023
Merged

e2e test: send coins #807

merged 8 commits into from
Nov 2, 2023

Conversation

pivilartisant
Copy link
Contributor

No description provided.

@pivilartisant pivilartisant linked an issue Oct 24, 2023 that may be closed by this pull request
e2e test: send coins #806
Closed
@pivilartisant pivilartisant marked this pull request as draft October 24, 2023 09:10
@pivilartisant pivilartisant changed the title Additional send test e2e test: send coins Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (631cbfe) 53.25% compared to head (ce8a3ac) 53.25%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   53.25%   53.25%           
=======================================
  Files          40       40           
  Lines        2334     2334           
=======================================
  Hits         1243     1243           
  Misses        922      922           
  Partials      169      169

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pivilartisant pivilartisant force-pushed the 806-e2e-test-send-coins branch 2 times, most recently from 7a81f31 to f9971f2 Compare October 24, 2023 13:47
@pivilartisant pivilartisant marked this pull request as ready for review October 24, 2023 15:51
@pivilartisant pivilartisant force-pushed the 806-e2e-test-send-coins branch 4 times, most recently from 183aa9c to d8f4891 Compare October 25, 2023 08:29
@pivilartisant pivilartisant force-pushed the 806-e2e-test-send-coins branch 2 times, most recently from da7544a to d4103dd Compare October 25, 2023 08:47
@pivilartisant pivilartisant force-pushed the 806-e2e-test-send-coins branch 4 times, most recently from bc88f8b to c4cfd15 Compare October 25, 2023 15:22
@pivilartisant pivilartisant force-pushed the 806-e2e-test-send-coins branch 3 times, most recently from c9da43d to 93be5f2 Compare October 30, 2023 08:36
Thykof
Thykof reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

web-frontend/cypress/e2e/acceptance/home/send.cy.tsx Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2023
View reviewed changes
web-frontend/cypress/support/e2e.ts Dismissed Show dismissed Hide dismissed
@pivilartisant pivilartisant force-pushed the 806-e2e-test-send-coins branch 4 times, most recently from b9b9a61 to 4d8fdca Compare November 2, 2023 10:29
@pivilartisant pivilartisant force-pushed the 806-e2e-test-send-coins branch 3 times, most recently from b2f9cb2 to 945e77f Compare November 2, 2023 10:53
mazmassa
mazmassa approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mazmassa mazmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some details do update but overall LGTM!

web-frontend/cypress/e2e/acceptance/home/send.cy.tsx Outdated Show resolved Hide resolved
@pivilartisant pivilartisant force-pushed the 806-e2e-test-send-coins branch 6 times, most recently from d16142a to 01f01e9 Compare November 2, 2023 13:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Thykof
Thykof approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thykof Thykof merged commit 7ee4b1e into main Nov 2, 2023
19 of 20 checks passed
@Thykof Thykof deleted the 806-e2e-test-send-coins branch November 2, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thykof Thykof Thykof approved these changes

@mazmassa mazmassa mazmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e test: send coins
3 participants
@pivilartisant @Thykof @mazmassa