DP-4572 - Re-work Dateline

[nstriedinger]

Description

I reworked the Dateline for the Drupal side. FYI -- I kept the <p> tag for current PL structure, but we will not be using this pattern on the Drupal end. (On the Drupal end, we're separating everything out and adding the Dateline, and reassembling programmatically.)

Related Issue / Ticket

• https://jira.state.ma.us/browse/DP-4572
• Github issue

Steps to Test

1. Read Ticket
2. go to ?p=pages-press-release
3. confirm span and bolded dateline.

Screenshots

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

[legostud]

What was the requirement for adding the extra class to make this bold instead of using the b tag?

Personally, I prefer the Drupal solution over what I created. My solution is a bit brittle so I'd be okay with deleting the ma__press__location-label Markup and CSS in favor of just adding the content within the first paragraph of the RTE block. Having it as part of the RTE block was my original solution, because it was simple and elegant.

[legostud]

font-weight should be part of a theme CSS file not part of the base CSS file (ie: /06-theme/04-templates/_press.scss file.

[nstriedinger]

Did I add this correctly?

[legostud]

yes that looks good

[jesconstantine]

@legostud I didn't fully understand your original change request - was it just to move the style rule into the theme scss or was there something else that you thought needed to be addressed here?

[nstriedinger]

@legostud -- @gleroux02 suggested I use a <span>.

[legostud]

This PR doesn't appear to solve any issues so I'm confused as to what's the goal with making this change?

The &__label was already uppercase and the text was already bold. The only difference I see here is that the — is no longer uppercase, which doesn't matter. This PR seems to be just adding bloat for no reason.

[legostud]

I feel like we're missing something. Maybe there is actually more work that needs to be done in Mayflower to match the approach that Mass Gov is using.

[legostud]

After talking with Jes, I better understand the desired outcome here. I would suggest removing all the code for the location-label and just add the content <span class="ma__rich-text__flame">Boston</span> &mdash; to the first paragraph of the Rich Text component in Mayflower. In the _rich-text.scss files we can add the styling needed to make the &__flame selector uppercase and bold similar to what you've already created.

What we're doing is adding a 'flame' option to the Rich Text pattern in Mayflower that you can leverage for your current solution.

[legostud]

This should be in the 'theme' file for rich-text. Otherwise this looks really good.

[legostud]

the font-weight: bold that is