fix(linux support): add the missing import for linux #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPodymov
suggested changes
Jan 12, 2021
| @@ -1,4 +1,7 @@ | |||
| import Foundation | |||
| #if canImport(FoundationNetworking) | |||
| import FoundationNetworking | |||
There was a problem hiding this comment.
Do you really need this import? There is not such line at https://github.com/yonaskolb/SwagGen/blob/master/Sources/SwagGen/GenerateCommand.swift.
There was a problem hiding this comment.
@RomanPodymov it is sadly required yes.
Yonas's repository either is not working on Linux due to the same issue.
Swift 5.1 moved all of Foundation's networking-related code to a separate module, which you have to include separately with import FoundationNetworking
Cf the following:
apple/swift-corelibs-foundation#2289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add linux support for Swift 5.3