Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed minSdk to 21 #18

Merged
merged 4 commits into from
May 25, 2023
Merged

Changed minSdk to 21 #18

merged 4 commits into from
May 25, 2023

Conversation

KitsuneFolk
Copy link
Contributor

No description provided.

@massivemadness
Copy link
Owner

massivemadness commented May 24, 2023 •
edited
Loading

Ktlint упал

Task :ktlint
/home/runner/work/Fragula/Fragula/app/src/main/kotlin/com/fragula2/sample/MainActivity.kt:83:2: Redundant newline (\n) at the end of file (final-newline)

Локально можешь запустить ./gradlew ktlintFormat, он поправит кодстайл

@KitsuneFolk
Copy link
Contributor Author

Эх, терминал не видит JAVA_HOME, не получается выполнить команду, завтра попробую разобраться, извини за неудобства 😞

@KitsuneFolk
Copy link
Contributor Author

Есть, удалило последнюю новую строку в MainActivity, сейчас сделаю комит

@massivemadness massivemadness merged commit c2d0e4d into massivemadness:develop May 25, 2023
1 check passed
@KitsuneFolk KitsuneFolk deleted the custom branch May 26, 2023 06:06
@massivemadness
Copy link
Owner

Все таки была причина оставить API 23. Но ничего, сделаю разные конфиги для приложения и либы

Снимок экрана 2023-05-27 в 14 55 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massivemadness massivemadness massivemadness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KitsuneFolk @massivemadness