bugs with deployments and environment configurations

[rzinger]

there are a couple bugs with environment variable templates:

• ehr app missing VITE_APP_ICD_SEARCH_ZAMBDA_ID (needed for condition and other searches on SOAP screens)
  • note: eRx configuration is necessary as well (probably documentation) to allow drug and allergy searches
• ehr app missing VITE_APP_GET_CONVERSATION_ZAMBDA_ID (needed for SMS to work properly)
• ehr zambdas are missing NLM_API_KEY reference (needed for ICD-10 searches) - ideally, this should be wrapped as an authenticated Oystehr service so EHRs don't have to sign up for their own API keys

on deployment scripts, some changes are needed

• in intake project zambdas, package-for-realease.sh, remove 'create-sample-appointments' zambda reference
• in intake project zambdas, deploy-zambdas.ts, remove the cron zambda CREATE-SAMPLE-APPOINTMENTS
• in intake project zambdas, common.ts, fix environment naming (need to generally adjust how deploy scripts talk to each other)
• in intake project apps, package.json scripts, deploy is not quite correct; need an environment setting, etc... some hardcoding issues... here's a sample that works:
  "build:development": "ENV=development npm run build-skeleton", "build-skeleton": "tsc && vite build --mode ${ENV}", "deploy": "ENV=development AWS_PROFILE=XXXXX CLOUDFRONT_ID=XXXXXXXXXXX pnpm run ci-deploy-skeleton", "ci-deploy-skeleton": "VITE_APP_ENV=${ENV} VITE_APP_SHA=${GIT_HEAD:-$(git rev-parse --short HEAD)} VITE_APP_VERSION=$(node -pe 'require(\"./package.json\").version') pnpm run build:${ENV} && aws s3 sync build/ s3://XXXXXXXX.ottehr.com --region us-east-1 --delete && aws cloudfront create-invalidation --distribution-id ${CLOUDFRONT_ID} --paths '/*' --region us-east-1"
• in ehr project apps, package.json scripts need some tweaks with environment, generally, here's a sample that seems to work:

  "deploy": "ENV=development AWS_PROFILE=XXXX PREFIX=development CLOUDFRONT_ID=XXXX pnpm run ci-deploy-skeleton",
  "ci-deploy-skeleton": "VITE_APP_SHA=${GIT_HEAD:-$(git rev-parse --short HEAD)} VITE_APP_VERSION=$(node -pe 'require(\"./package.json\").version') pnpm run build:development && aws s3 sync build/ s3://XXXXX.ottehr.com --region us-east-1 --delete && aws cloudfront create-invalidation --distribution-id ${CLOUDFRONT_ID} --paths '/*' --region us-east-1"
  
  

[GiladSchneider]

Are these up to date?