Check if any packages are available before calling pip install #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error when no packages are available for update
Remove extra space
massongit
reviewed
Mar 1, 2020
smac89
changed the title
|
I was thinking to add a check for system python, and avoid updating using pip because most of the time those require root permissions. Maybe instead, just print the command needed and exit, or attempt to update using sudo. What do you think? Apart from that, this is good to merge 🚢. |
|
I think that it is better to just print the command needed if the system python needs upgrade packages. |
|
I created a issue: #5 |
|
I merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error when no packages are available for update