Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace base64 with cl-base64 #2

Closed
wants to merge 1 commit into from
Closed

Conversation

naryl
Copy link

@naryl naryl commented Feb 12, 2020

base64 is only used by this library while cl-base64 is used by 23 others. It normally wouldn't be a problem but cl-base64 uses base64 as a nickname for its package so you can't load both base64 and cl-base64 in the same system. That's a huge problem because it means that you can't e.g. load sha1 which depends on base64 and drakma which depends on cl-base64.

@naryl
Copy link
Author

naryl commented Mar 3, 2020

@massung Is something wrong with this PR? Can you at least comment on it?

@massung
Copy link
Owner

massung commented Mar 3, 2020

Sorry, life taking priority at the moment. The PR is fine, but I'm not going to merge it.

While I can understand the desire in your PR, I wrote my base64 for myself and it's what I want to use for my packages. I fully control it as opposed to depending on someone else (which actually matters in the CL community as code appears and becomes abandoned quite frequently). And I use it in several packages of mine other than just the sha1 package, including some packages that use both it and sha1. Changing what this package uses would mean my other code now importing two different base64 libraries, which I don't want any more than you do. 😄

I could be convinced to rename my base64 package to something else, but I honestly haven't put much thought into that beyond asking myself if I'd be willing to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants