Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on IE10 #14

Closed
yaniv691 opened this issue Sep 23, 2014 · 6 comments
Closed

Not working on IE10 #14

yaniv691 opened this issue Sep 23, 2014 · 6 comments

Comments

@yaniv691
Copy link

I really like your mixin collection, but I can't seem to get it to work in IE10. The mixin doesn't insert "display: -ms-flexbox" into the CSS, which means IE10 doesn't get it. When I hard code "display: -ms-flexbox" (without using the mixin) into an element's CSS, it works.
I'm using Compass 1.0.0.alpha.12 and Sass 3.4.2 .

@mastastealth
Copy link
Owner

I take it you're using the compass version of the mixin? I know the standard one definitely has the -ms prefix, but someone else had worked on the Compass version so I'd have to look into that.

@yaniv691
Copy link
Author

Actually, I''m not using the Compass version, just the regular SCSS file which I import into my project.

@mastastealth
Copy link
Owner

Welp, that's confusing. Line 67:
https://github.com/mastastealth/sass-flex-mixin/blob/master/flex.scss#L67

-definitely has what you need. I honestly don't know what to say. Can you see if that line still exists?

@yaniv691
Copy link
Author

Yep, that line exists. The weird thing is when using @include flexbox; in an element's SCSS, the CSS file rendered is shows this:
display: -webkit-box;
display: -webkit-flex;
display: flex;
instead of this
display: -webkit-box;
display: -webkit-flex;
display: -moz-flex;
display: -ms-flexbox;
display: flex;

@yaniv691
Copy link
Author

I got this fixed now! It has nothing to do with your mixin collection, but rather the configuration of the Grunt Autoprefixer task. It was set to "last 1 version" (IE11) which in turn removed all irrelevant vendor-prefixed CSS values. I fixed this by changing the option to "last 2 versions".

Thanks. and sorry for buggin...

@mastastealth
Copy link
Owner

All's well that ends well. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants