Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 outline:none is broken #296

Closed
oskar-gmerek opened this issue Oct 26, 2023 · 3 comments · Fixed by #299
Closed

🐞 outline:none is broken #296

oskar-gmerek opened this issue Oct 26, 2023 · 3 comments · Fixed by #299
Assignees
@1aron
Labels
bug Something isn't working released on @beta released on @rc

Comments

@oskar-gmerek
Copy link
Contributor

Description

outline:* is always rewrited in css as outline:* solid. Because of this behavior there is impossible to use outline:none because this is translated to outline:none solid what is invalid property value.

There is also no unit tests cover that case.

Reproduction

  1. Add class outline:none to the input.
  2. See the broken css in dev tools.

System Informations

N/A
@oskar-gmerek oskar-gmerek added the bug Something isn't working label Oct 26, 2023
@1aron 1aron self-assigned this Oct 27, 2023
@1aron 1aron added the css label Oct 27, 2023
@lesha1201 lesha1201 mentioned this issue Nov 1, 2023
Merged
@1aron 1aron closed this as completed in f98bc57 Nov 3, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023

🎉 This issue has been resolved in version 2.0.0-beta.193 🎉

The release is available on:

Your semantic-release bot 📦🚀

@1aron
Copy link
Member

1aron commented Nov 3, 2023

@oskar-gmerek Thank you for describing the issue in detail. It has been resolved in https://github.com/master-co/css/releases/tag/v2.0.0-beta.193.

0Miles pushed a commit that referenced this issue Nov 6, 2023
@1aron @0Miles
Fix: outline:none doesn't work and autofill solid is deprecated, r…
eac4515 
…esolved #296 #299
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 2.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1aron 1aron

Labels
bug Something isn't working released on @beta released on @rc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(CSS): outline doesn't handle some keyword values lesha1201/css
2 participants
@1aron @oskar-gmerek