Replace memory writes with mask in sse4.1 aom/vpx parsing, fix edge case #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a single chunk had >=10,000 frames, there would be a singular line of text causing the sse4.1 code to report a garbage value, which happened because of an invalid assumption that the number of digits of the buffered frames and encoded frames is always the same. This also affected the fallback function but in a non-obnoxious way, causing it to just return
Nonein this edge case instead of a garbage value.This PR fixes that issue, along with replacing the very suboptimal writes back to main memory (which caused
parse_encoded_framesto be marked asunsafe) in the sse4.1 code with significantly more sensible masking of xmm registers based on the number of digits found.