Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github cache action instead of using gha. Dedupe Dockerfile #594

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

luigi311
Copy link
Contributor

Action:

  • Use github cache action instead of using gha for the cache-from/to, this allows us to use the cache from the docker stage in the docker-publish stage and also doesnt show an artifact on the github action page.
  • Removed digest from docker stage as there is no digest since its not uploaded anywhere.

Docker:

  • Reduce duplication so its easier to change the base image and add dependencies in a single place instead of in multiple place like before with the build dependencies.
  • Removed rsync as that was a dependency I added when testing solutions around and isnt needed anymore

@mergify mergify bot merged commit 507a6e3 into master-of-zen:master Mar 16, 2022
@luigi311 luigi311 deleted the cache branch March 17, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants