Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data streams when encoding audio #616

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Conversation

GaveUp
Copy link
Contributor

@GaveUp GaveUp commented Apr 17, 2022

If an input file contains any data streams audio encoding will fail when trying to write a non-supported stream to the intermediary mkv. This removes any data streams found in the input.

Output {
    status: ExitStatus(
        unix_wait_status(
            256,
        ),
    ),
    stdout: "",
    stderr: "[matroska @ 0x565479976f00] Only audio, video, and subtitles are supported for Matroska.\nCould not write header for output file #0 (incorrect codec parameters ?): Invalid argument\nError initializing output stream 0:1 -- \n",
}

@redzic
Copy link
Collaborator

redzic commented Apr 17, 2022

I think it would be easier to do this by just adding -dn to the parameters like we do with -vn, if that also fixes it.

@GaveUp
Copy link
Contributor Author

GaveUp commented Apr 17, 2022

You are correct. -dn makes more sense and has the same effect.

Copy link
Collaborator

@redzic redzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit f0d3f0e into master-of-zen:master Apr 17, 2022
Fuchs4 pushed a commit to Fuchs4/Av1an that referenced this pull request May 10, 2022
Fuchs4 pushed a commit to Fuchs4/Av1an that referenced this pull request Aug 18, 2022
Fuchs4 pushed a commit to Fuchs4/Av1an that referenced this pull request Aug 24, 2022
Fuchs4 pushed a commit to Fuchs4/Av1an that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants